Refactored platform management Git URL into environment variable #41
+53
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertNorthard
force-pushed
the
feature/platform-management-git-url-env-variable
branch
2 times, most recently
from
e29171e
to
e3f14c3
Compare
RobertNorthard
commented
Mar 1, 2017
projects/jobs/jobs.groovy
Outdated
| @@ -1,7 +1,3 @@ | |||
| // Constants | |||
| def gerritBaseUrl = "ssh://jenkins@gerrit:29418" | |||
| def cartridgeBaseUrl = gerritBaseUrl + "/cartridges" | |||
There was a problem hiding this comment.
Removed cartridgeBaseUrl as it is no longer used since the introduction of PR #32
Signed-off-by: Northard, Robert A <[email protected]>
RobertNorthard
force-pushed
the
feature/platform-management-git-url-env-variable
branch
from
d26329a
to
4e7c7ea
Compare
|
Tested with following steps:
The repositories are configured as expected if ADOP_PLATFORM_MANAGEMENT_GIT_URL environment variable is set. They fall back to default gerrit repositories if the mentioned variable is not set. Happy for this PR to be closed. |
|
@subodh-hatkar thanks for testing. @nickdgriffin do you have any feedback on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored platform management Git URL into environment variable
ADOP_PLATFORM_MANAGEMENT_GIT_URLThis change was introduced because;
Features